Delete OreSatId, NodeId #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OreSatId has been replaced by Consts and NodeId by Card/card.csv. At this point I believe all other projects using these classes have been updated.
ryanpdx
reviewed
Nov 5, 2024
|
Sure, thoughts on name? |
|
|
ryanpdx
approved these changes
Nov 8, 2024
Consts by itself was found to be a bit too generic. While I had initially proposed Consts->MissionConsts I think it works out a bit better to do it the way in the title. Mission.default() or Mission.ORESAT0 reads a bit better and the dataclass is where the actual consts are. This will break all the other projects using oresat-configs but I don't really want to go through a backwards compatible release process to smoothly fix up everything. I'll try to patch what we have and hopefully anything I miss will yell loudly.
ryanpdx
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OreSatId has been replaced by Consts and NodeId by Card/card.csv. At this point I believe all other projects using these classes have been updated.