condition: throw an error if an unknown condition is used in json (#68)

Closes #45
ory · Jun 6, 2017 · c8b0a33 · c8b0a33
1 parent 208aa53
commit c8b0a33
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/condition.go b/condition.go
@@ -55,8 +55,10 @@ func (cs Conditions) UnmarshalJSON(data []byte) error {
 	}
 
 	for k, jc := range jcs {
+		var found bool
 		for name, c := range ConditionFactories {
 			if name == jc.Type {
+				found = true
 				dc = c()
 
 				if len(jc.Options) == 0 {
@@ -72,6 +74,10 @@ func (cs Conditions) UnmarshalJSON(data []byte) error {
 				break
 			}
 		}
+
+		if !found {
+			return errors.Errorf("Could not find condition type %s", jc.Type)
+		}
 	}
 
 	return nil

diff --git a/condition_test.go b/condition_test.go
@@ -54,3 +54,12 @@ func TestMarshalUnmarshal(t *testing.T) {
 	assert.IsType(t, &EqualsSubjectCondition{}, cs["owner"])
 	assert.IsType(t, &CIDRCondition{}, cs["clientIP"])
 }
+
+func TestUnmarshalFails(t *testing.T) {
+	cs := Conditions{}
+	require.NotNil(t, json.Unmarshal([]byte(`{
+	"somefield": {
+		"type": "DoesntExist"
+	}
+}`), &cs))
+}