Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ruff as linter and formatter. #113

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

xbarra
Copy link
Collaborator

@xbarra xbarra commented Aug 12, 2024

Co-authored-by: Arfima Dev dev@arfima.com
Signed-off-by: Xavier Barrachina Civera xbarrachina@arfima.com

@xbarra xbarra force-pushed the ruff_linter branch 2 times, most recently from ab001ed to 9829981 Compare August 13, 2024 08:24
@xbarra
Copy link
Collaborator Author

xbarra commented Aug 13, 2024

Following the discussion in #111 I configured ruff as linter and formatter, removing the others.

I am commenting the markdown pre-commit until #94 is fixed

@xbarra xbarra force-pushed the ruff_linter branch 2 times, most recently from 024cbeb to 293db1b Compare August 13, 2024 17:31
Co-authored-by: Arfima Dev <dev@arfima.com>
Signed-off-by: Xavier Barrachina Civera <xbarrachina@arfima.com>
@xbarra xbarra force-pushed the ruff_linter branch 2 times, most recently from ae05931 to 3ffe2d1 Compare August 14, 2024 06:35
pyproject.toml Outdated Show resolved Hide resolved
@ciaransweet
Copy link
Contributor

Out of interest @xbarra is this PR rebased onto my commit? I'm surprised to see so many formatting changes, especially as my PR did a lot of it, I'd only expect a few files from the black/ruff differences

@xbarra xbarra force-pushed the ruff_linter branch 2 times, most recently from e31cdc3 to 28164f7 Compare August 14, 2024 15:16
@xbarra
Copy link
Collaborator Author

xbarra commented Aug 14, 2024

Out of interest @xbarra is this PR rebased onto my commit? I'm surprised to see so many formatting changes, especially as my PR did a lot of it, I'd only expect a few files from the black/ruff differences

@ciaransweet
It is rebased. The formatting changes are because the configuration in pyproject.toml adds several rules.

@ciaransweet
Copy link
Contributor

Out of interest @xbarra is this PR rebased onto my commit? I'm surprised to see so many formatting changes, especially as my PR did a lot of it, I'd only expect a few files from the black/ruff differences

@ciaransweet It is rebased. The formatting changes are because the configuration in pyproject.toml adds several rules.

Gotcha, thanks!

@joemoorhouse joemoorhouse merged commit 2ad34f4 into os-climate:main Aug 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants