Add generic class type #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 95.80% 95.92% +0.12%
==========================================
Files 13 13
Lines 786 835 +49
==========================================
+ Hits 753 801 +48
- Misses 33 34 +1 ☔ View full report in Codecov by Sentry. |
SoongNoonien
force-pushed
the
class_types
branch
4 times, most recently
from
2a9b656
to
72b551d
Compare
SoongNoonien
force-pushed
the
class_types
branch
from
72b551d
to
3c76945
Compare
fingolfin
reviewed
Oct 11, 2024
Comment on lines
+17
to
+18
| number_of_conjugacy_classes(class::GenericConjugacyClass) | ||
| number_of_conjugacy_classes(class::SimpleGenericConjugacyClass) |
There was a problem hiding this comment.
Suggested change
| number_of_conjugacy_classes(class::GenericConjugacyClass) | |
| number_of_conjugacy_classes(class::SimpleGenericConjugacyClass) | |
| number_of_conjugacy_classes(class::GenericConjugacyClass) |
| order(t::Table, class::Int64) = order(conjugacy_class_type(t, class)) | ||
|
|
||
| @doc raw""" | ||
| number_of_conjugacy_classes(class::GenericConjugacyClass) |
There was a problem hiding this comment.
Suggested change
| number_of_conjugacy_classes(class::GenericConjugacyClass) | |
| number_of_conjugacy_classes(class::AbstractGenericConjugacyClass) |
fingolfin
reviewed
Oct 11, 2024
| @doc raw""" | ||
| info(t::Table, class::Int64) | ||
|
|
||
| Return the infolists of the class type `class` of the table `t`. |
There was a problem hiding this comment.
TODO: extend this to mention that the meaning of the content of these infolists differs between tables and the table info string usually contains more info about the format/content.
fingolfin
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.