-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starship integration #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice start! Thanks for driving this forward!
I have not looked at the test details. yet but I was wondering how this PR relates to #55 and what the bigger picture is?
With starship tests in tests/ folder, I would expect them to run in CI. Is this what you want to do?
@alpe sorry you had to review this, but this is still a draft PR and is not fully ready to be merged. |
As for what the bigger picture is with Starship, we can make an issue or a design doc of sorts needed. But yes we will run these tests in the CI as well, as well as for setup for anyone who wants to use Starship, for let's say frontend, backend or even contract development. I think we have to figure out where best to place the |
trim starship integration
push: | ||
branches: | ||
- main | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sure if we want to run this on every PR, takes around 15mins to run the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work, the demo we showed at Osmocon would not be possible without it. 🙏
This has been pending for some time due to my other responsibilities. Sorry for this! |
Overview
In this PR we add
starship
integration and tests.Implementation
tests/starship
dirtests/e2e/testdata
totests/testdata
, so that the same contracts and be used for e2e tests as well as starship teststests/starship/setup
pkg to initialize chains with the mesh contracts and perform e2e handshakesCI
CI has been tested here: https://github.com/osmosis-labs/mesh-security-sdk/actions/workflows/starship-e2e-tests.yml
Why
With
starship
we are able to test againstStarship also gives a nice playground and a good start to be able to create an integrated qa environment.
Since Starship acts like a complete blackbox testing framework (we only interact via RPC endpoints), work needed to adapt
tests/e2e
tests where all functions and steps to initialize new chains with mesh-contracts gets codified and tested. We make little to no assumptions about the infra, so can easily create a util to initialize contracts.Starship integration will also give chains that want to adopt mesh-security a way to quickly test out compatibility via and e2e testing setup.
Future work
tests/starship/setup
pkg integrated withtests/e2e
packageLimitations