BE-648 | Test pools: include 0 liquidity pools

[deividaspetraitis]

This Adds URL query param to include 0 liquidity pools in the response to address errors such as:

FAILED tests/test_candidate_routes.py::TestCandidateRoutes::test_all_valid_tokens[http://localhost:9092-ibc/912275A63A565BFD80734AEDFFB540132C51E446EAC41483B26EDE8A557C71CF] - AssertionError: Error: pool ID 1883 not found in test data
FAILED tests/test_candidate_routes.py::TestCandidateRoutes::test_all_valid_tokens[http://localhost:9092-ibc/F17CCB4F07948CC2D8B72952C2D0A84F2B763962F698774BB121B872AE4611B5] - AssertionError: Error: pool ID 1883 not found in test data
FAILED tests/test_candidate_routes.py::TestCandidateRoutes::test_all_valid_tokens[http://localhost:9092-ibc/D7D6DEF2A4F7ED0A6F5F0E266C1B2C9726E82F67EBBE49BBB47B3DEC289F8D7B] - AssertionError: Error: pool ID 1890 not found in test data
FAILED tests/test_candidate_routes.py::TestCandidateRoutes::test_all_valid_tokens[http://localhost:9092-ibc/B2BD584CD2A0A9CE53D4449667E26160C7D44A9C41AF50F602C201E5B3CCA46C] - AssertionError: Error: pool ID 1890 not found in test data

Summary by CodeRabbit

• New Features
  • Updated the API endpoint for fetching pool data to include a minimum liquidity requirement, enhancing data retrieval accuracy.
• Bug Fixes
  • Improved error handling during pool data fetching to ensure robustness in case of request exceptions.

[coderabbitai]

Walkthrough

The pull request modifies the POOLS_ENDPOINT constant in the tests/data_service.py file, changing its value to include a query parameter for minimum liquidity. This adjustment affects how pool data is fetched, filtering results based on the specified liquidity requirement. The existing logic for fetching pools and updating liquidity caps remains intact, with error handling and pagination still in place.

Changes

File	Change Summary
tests/data_service.py	Updated POOLS_ENDPOINT from '/stream/pool/v1/all' to '/stream/pool/v1/all?min_liquidity=0'.

Possibly related PRs

• SQS-404 | E2E Tests: Compute liquidity with CoinGecko #513: Introduces the COINGECKO_API_KEY environment variable for E2E tests that compute liquidity using CoinGecko, relevant to the pool data retrieval logic.
• SQS-404 | E2E Tests: Compute liquidity with CoinGecko ( backport ) #516: Backport PR that also adds the COINGECKO_API_KEY for E2E tests, indicating a connection to liquidity calculations pertinent to the main PR.

Suggested labels

A:backport/v26.x

Suggested reviewers

• p0mvn
• cryptomatictrader

Poem

🐇 In the fields where data flows,
A tweak to pools, as everyone knows.
With liquidity set to zero,
Our fetching now is a hero!
Hop along, let’s fetch with glee,
For pools are richer, come see! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

tests/data_service.py (2)

Line range hint 82-83: Fix duplicate nested loop.

There's a duplicate for pool in pools: loop that should be removed:

- for pool in pools:
    for pool in pools:
        update_pool_liquidity_cap(pool)
+ for pool in pools:
+     update_pool_liquidity_cap(pool)

---

Line range hint 89-91: Consider enhancing error handling with more detailed logging.

The current error handling could be improved to provide more context about which pagination batch failed and how many pools were successfully processed before the error occurred.

         except requests.exceptions.RequestException as e:
-            print(f"Error fetching data from Numia: {e}")
+            print(f"Error fetching pools from Numia (offset: {next_offset}, batch: {batch_size}): {e}")
+            print(f"Successfully processed {len(all_pools)} pools before error")
             break

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9927d46 and bec390a.

📒 Files selected for processing (1)

• tests/data_service.py (1 hunks)

🔇 Additional comments (1)

tests/data_service.py (1)

9-9: LGTM! The endpoint modification aligns with PR objectives.

The addition of min_liquidity=0 parameter will ensure that zero liquidity pools are included in the response, which should resolve the test failures mentioned in the PR description.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud