forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardised strings qa #3202
Merged
Merged
Standardised strings qa #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from locale strings
[CI SKIP]
…ktop into standardised_strings
…d new i18n component
…r string selection
yougotwill
reviewed
Sep 17, 2024
yougotwill
reviewed
Sep 17, 2024
yougotwill
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed last changes
Bilb
force-pushed
the
standardised_strings_qa_2
branch
5 times, most recently
from
September 19, 2024 09:07
095e100
to
a62e7dd
Compare
yougotwill
approved these changes
Sep 20, 2024
LGTM 🚢 |
Bilb
force-pushed
the
standardised_strings_qa_2
branch
from
September 23, 2024 06:00
a62e7dd
to
71206ae
Compare
Bilb
force-pushed
the
standardised_strings_qa_2
branch
from
September 23, 2024 06:04
71206ae
to
8dd9272
Compare
Aerilym
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.