-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove delete_after_merge functionality #243
base: develop
Are you sure you want to change the base?
Conversation
Thanks for your interest in palantir/bulldozer, @anishagg17! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Hey @anishagg17, thanks for the PR. Do you mind also removing the examples as well?
https://github.com/palantir/bulldozer/blob/19a4b0800b00bab36aaf30366800f1016983efb5/README.md#bulldozeryml-specification |
sure, @asvoboda I have removed it from some tests too and even from the |
Oh, I think that after changing the |
If you run It looks like the |
Yeah, replaced it with an |
@asvoboda can we merge this one? |
Fixes: #212
removed code for attemptDelete and DeleteAfterMerge functionality