Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arguments for _count fields #330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

f8k8
Copy link
Contributor

@f8k8 f8k8 commented Mar 8, 2024

Fixes #322

@AhmedElywa
Copy link
Collaborator

This one will need to update all generators, not only the SDL.
If you can do it, thank you.
If not, I will do it

@f8k8
Copy link
Contributor Author

f8k8 commented Mar 15, 2024

I've only looked at the SDL one as that's the one we use. I can try to find time to look at the others but it might not be for a while.

@f8k8
Copy link
Contributor Author

f8k8 commented Jul 23, 2024

I've had another look at this and I think the change already applies to all generators, as it's in the packages/generator/src/Generators.ts and packages/plugins/src/select.ts files, and not anything in the specific SDL generator. The snapshots updated are the SDL one and the graphql-modules one. The Nexus snapshot hasn't changed, but looking at it I think the nexus one might already have the arguments for counts, though I'm not sure as I don't really know anything about Nexus.

@hdngr
Copy link

hdngr commented Nov 8, 2024

would love to see this included! Let me know where to pitch in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_count doesn't accept arguments
3 participants