Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept AsyncIterables being passed to Response #341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Accept AsyncIterables being passed to Response #341

wants to merge 1 commit into from

Conversation

mjsir911
Copy link

@mjsir911 mjsir911 commented May 20, 2024 •
edited
Loading

Fixes pallets/flask#5322

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@mjsir911
Copy link
Author

I want to add tests for this somehow

@mjsir911 mjsir911 mentioned this pull request May 20, 2024
Closed
@mjsir911 mjsir911 force-pushed the fix_response_typing branch 3 times, most recently from a6bf4ae to c9323e1 Compare May 20, 2024 14:43
@mjsir911 mjsir911 marked this pull request as ready for review May 20, 2024 14:43
@mjsir911
Copy link
Author

mjsir911 commented May 20, 2024 •
edited
Loading

@davidism ready for review, would like extra eyes on the test specifically

@mjsir911
Copy link
Author

Add an entry in CHANGES.rst summarizing the change and linking to the issue.

I've been told I don't need to do this and it will be gotten to later.

@mjsir911
Copy link
Author

mjsir911 commented May 20, 2024 •
edited
Loading

It would be cool if ResponseValue in typing.py could be updated too but adding AsyncIterator[bytes] or similar causes a lot of errors.

@mjsir911 mjsir911 force-pushed the fix_response_typing branch 4 times, most recently from bea08c1 to 88f728b Compare May 21, 2024 01:57
@CoolCat467
Copy link

Is there anything stopping this from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResponseValue Typing issue
2 participants
@mjsir911 @CoolCat467