You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If server_name is passed to Map.bind_from_environ, and a subdomain is not passed in (as usually it's not possible to know it), it will try to detect the subdomain by removing server_name as a suffix from host. This restricts routing to only the configured server_name, even if we don't have any subdomain-based routing rules.
Move Flask's subdomain_matching param into Map (where host_matching is already). bind_to_environ should not extract a subdomain unless it's enabled.
The text was updated successfully, but these errors were encountered:
default_subdomain should be used if it's set and server_name is not a suffix of Host. Currently "<invalid>" is always used, and I'm not sure this is correct since it causes wildcard subdomain="<name>" rules to still match, even though the comment indicates it should 404. So maybe evaluate removing "<invalid>" as well.
Or maybe it shouldn't. Maybe knowing it's not a valid subdomain, rather than using the default, is more useful? "<invalid>" isn't mentioned anywhere in the docs, and is only present in three tests that don't actually test routing to it, only that it is what is set on the adapter.
If
server_name
is passed toMap.bind_from_environ
, and asubdomain
is not passed in (as usually it's not possible to know it), it will try to detect the subdomain by removingserver_name
as a suffix fromhost
. This restricts routing to only the configuredserver_name
, even if we don't have any subdomain-based routing rules.Move Flask's
subdomain_matching
param intoMap
(wherehost_matching
is already).bind_to_environ
should not extract a subdomain unless it's enabled.The text was updated successfully, but these errors were encountered: