improve subdomain and host matching #3006
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
force-pushed
the
map-subdomain
branch
from
514d260
to
49365b8
Compare
davidism
force-pushed
the
map-subdomain
branch
from
49365b8
to
e6547d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maptakessubdomain_matching, moving the behavior out of Flask pallets/flask#5634. It's enabled by default to match current behavior. If it andhost_matchingare disabled, the request'sHostdoesn't factor into routing at all.bind_to_environserver_nameis not used ifhost_matchingis enabled, otherwise it would restrict routing to only that host. Ifsubdomain_matchingis enabled and a subdomain couldn't be detected,default_subdomainis used if set, rather than always"<invalid>".This did not affect any existing tests. Leaving as draft until I have a chance to write tests and docs for all this. I also want to consider the use of `"" more, whether it should always be used (current behavior) or never be used (further than this PR).
fixes #3005