chore(rpc): make TransactionCompat::fill stateful
#11732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
A-rpc
emhane
requested review from
mattsse,
Rjected,
fgimenez,
onbjerg and
gakonst
as code owners
Rjected
requested changes
Oct 21, 2024
Rjected
requested changes
Oct 22, 2024
Comment on lines
+111
to
+117
| let deposit_receipt_version = self | ||
| .inner | ||
| .provider() | ||
| .receipt_by_hash(hash) | ||
| .ok() // todo: change sig to return result | ||
| .flatten() | ||
| .and_then(|receipt| receipt.deposit_receipt_version); |
There was a problem hiding this comment.
let's do the todo here, maybe the error can be an associated type?
There was a problem hiding this comment.
it's quite a big change, effects signature of more rpc compat signatures, suggest it's done in a separate pr
There was a problem hiding this comment.
alright, let's make an issue to track
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11708
Closes #11164
Makes
TransactionCompat::filltake ref to self, to be able to add necessary data toOpTxBuilderto resolve the deposit receipt version for a transaction response