Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add geometry to database args #11828

Merged
merged 34 commits into from
Oct 29, 2024
Merged

feat: add geometry to database args #11828

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
773b743
add geometry field to DatabaseArguments, methods with_geometry to pro…
evchip Oct 17, 2024
6c31027
add max_size and growth_step to DatabaseArgs with default values of 4…
evchip Oct 17, 2024
af61457
make geometry fn const
evchip Oct 17, 2024
4f2153a
fmt
evchip Oct 17, 2024
e90bc62
remove Option on geometry, remove generic in favor of <Range<usize>, …
evchip Oct 17, 2024
7ea1802
change max_size and growth_step to Option
evchip Oct 17, 2024
12a5744
remove default values for max_size and growth_step, remove custom Def…
evchip Oct 17, 2024
e8d9f8a
remove if any part of comment on geometry fn
evchip Oct 18, 2024
2ff4489
import reth-node-types into storage crate
evchip Oct 20, 2024
5049b9e
import reth-node-types into node core crate
evchip Oct 20, 2024
8a46cae
implement value parser on max_size and growth_step db args; add tests…
evchip Oct 20, 2024
35acd55
create struct ByteSize and custom implement FromStr trait + fmt:Display
evchip Oct 20, 2024
c689067
modify DatabaseArguments::with_geometry to use Option<ByteSize> for m…
evchip Oct 20, 2024
0e6125f
Merge branch 'main' into add-geometry-to-db-args
evchip Oct 20, 2024
2903778
split test_command_parser_max_size_and_growth_step_from_str_invalid_u…
evchip Oct 20, 2024
53b3519
adds --db.max-size and --db.growth-step to docs
evchip Oct 20, 2024
0a00472
cargo fmt
evchip Oct 20, 2024
63003a3
Merge branch 'main' into add-geometry-to-db-args
evchip Oct 22, 2024
c0dd17c
pass default_page_size() to page_size field of geometry to maintain o…
evchip Oct 22, 2024
746716f
Merge branch 'main' into add-geometry-to-db-args
evchip Oct 22, 2024
39bdfbc
add --db.max-size and --db.growth-step back into reth book after merg…
evchip Oct 22, 2024
3a4f875
run linter
evchip Oct 22, 2024
b5cc47b
change max_size and growth_step args on with_geometry to type usize a…
evchip Oct 23, 2024
9b4948b
map max_size and growth_step args from Option<ByteSize> to Option<usi…
evchip Oct 23, 2024
03ea71a
move parse_byte_size down below LogLevelValueParser struct
evchip Oct 23, 2024
9dd477c
remove unused import reth-node-types
evchip Oct 23, 2024
5644c95
lint fmt
evchip Oct 23, 2024
7b01504
move ByteSize struct from reth-node-types to reth-node-core database.rs
evchip Oct 23, 2024
b465c69
remove reth-node-types as dependency in reth-node-core, as ByteSize s…
evchip Oct 23, 2024
f6ec451
remove unused geometry function
evchip Oct 23, 2024
e3b4327
Merge branch 'paradigmxyz:main' into add-geometry-to-db-args
evchip Oct 25, 2024
f682d82
Merge branch 'main' into add-geometry-to-db-args
mattsse Oct 29, 2024
15d8c64
cleanup
mattsse Oct 29, 2024
09f8b3b
clippy
mattsse Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions book/cli/reth/db.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/db/diff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/debug/build-block.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/debug/execution.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/debug/in-memory-merkle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/debug/merkle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/debug/replay-engine.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/import.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/init-state.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/init.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/node.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/p2p.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/prune.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/recover/storage-tries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/stage/drop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/stage/dump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/stage/run.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
6 changes: 6 additions & 0 deletions book/cli/reth/stage/unwind.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ Database:

[possible values: true, false]

--db.max-size <MAX_SIZE>
Maximum database size (e.g., 4TB, 8MB)

--db.growth-step <GROWTH_STEP>
Database growth step (e.g., 4GB, 4KB)

--db.read-transaction-timeout <READ_TRANSACTION_TIMEOUT>
Read transaction timeout in seconds, 0 means no timeout

Expand Down
1 change: 1 addition & 0 deletions crates/node/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ reth-network-peers.workspace = true
reth-consensus-common.workspace = true
reth-prune-types.workspace = true
reth-stages-types.workspace = true
reth-node-types.workspace = true

# ethereum
alloy-primitives.workspace = true
Expand Down
Loading
Loading