Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(trie): replace TrieAccount by alloy Account #12625

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(trie): replace TrieAccount by alloy Account #12625

wants to merge 1 commit into from

Conversation

kamuik16
Copy link
Contributor

Closes #12318

@shekhirin shekhirin added C-enhancement New feature or request A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain and removed C-enhancement New feature or request labels Nov 18, 2024
shekhirin
shekhirin reviewed Nov 18, 2024
View reviewed changes
crates/trie/common/src/account.rs
/// Hash of the account's bytecode.
pub code_hash: B256,
}
pub struct TrieAccount(AlloyTrieAccount);
Copy link
Collaborator

@shekhirin shekhirin Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we instead use the Alloy struct directly in all places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this but there are some foreign impls implemented on this type which are violated when used Alloy struct instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@shekhirin shekhirin shekhirin left review comments

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trie: replace TrieAccount by alloy Account
3 participants
@kamuik16 @shekhirin @mattsse