Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export psis function #1566

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Export psis function #1566

merged 2 commits into from
Nov 14, 2023

Conversation

sims1253
Copy link
Contributor

I wanted to do this since forever and finally got around to it. I am not sure if there is a more elegant solution to exporting without a version without the dot without change all the internal calls to .psis.
Let me know if anything needs change.

@paul-buerkner
Copy link
Owner

Looks but, but why have both .psis and psis.brmsfit now? Can you check where .psis is applied and then just change it to psis accordingly. Or is there something that's blocking that change?

@sims1253
Copy link
Contributor Author

sims1253 commented Nov 14, 2023

You use the prepended dot to do_call the criterion functions in

brms/R/loo.R

Line 247 in fe7023f

out <- do_call(paste0(".", criterion), args)

So you either have to rename all criterion functions (potentially also exporting them), handle the extra case for psis not having a prepended dot any more or keep .psis as the wrapper.

@paul-buerkner
Copy link
Owner

ah makes sense. So lets just leave it like this then. I will merge this soon.

@paul-buerkner
Copy link
Owner

Merging now.

@paul-buerkner paul-buerkner merged commit e2989a3 into paul-buerkner:master Nov 14, 2023
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants