Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for fiona 1.10 #301

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fix for fiona 1.10 #301

merged 3 commits into from
Sep 27, 2024

Conversation

perrygeo
Copy link
Owner

Fiona behavior changed slightly when opening GeoJSON strings. See Toblerity/Fiona#1455

We can work around this in a backwards compatible way by catching the ValueError so that GeoJSON strings take the json.loads code path.

@perrygeo
Copy link
Owner Author

Python 3.8 is failing and I have no clue why.

    def _is_zip(path):
        """Check if a given path is a zipfile"""
>       parsed = fiona.path.ParsedPath.from_uri(path)
E       AttributeError: module 'fiona' has no attribute 'path'

It's only the geopandas tests failing. FWIW Geopandas is now on minimum Python 3.10 and Python 3.8 is EOL as of this month. So my plan is to bump this project to min version 3.9 and remove it.

@perrygeo perrygeo merged commit 7ac1c22 into master Sep 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant