-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated matchTemplate and added an example #389
Updated matchTemplate and added an example #389
Conversation
@padom checkout the example I wrote. matchTemplate now returns the following array:
|
I saw that is returning array but I can't get him in nodejs. When I whant to show data that is returned in console.log I see just the Matrix object, not array that is returned. |
I can get it with output[1] and output[2] etc. |
If I go to install npm module like fork or patch, over package.json, I get an error. |
Same question here :) (and thanks for the fix !) |
@peterbraden can you kindly merge the fix? |
Yep! Sorry for the delay. |
Updated matchTemplate and added an example
i don't get this one. i think that this is overloading matchTemplate too much and diverges the api of node from the underlying library. See my example in #419 (https://github.com/acinader/node-opencv/blob/40d5036627a830e508eac0ebf8f2c1579dfe3ccb/examples/match-template.js) which draws the rectangle on the match in the same way that the samples in opencv do: https://github.com/Itseez/opencv/blob/master/samples/cpp/mask_tmpl.cpp if we want to augment node_opencv to make drawing the match, i'd suggest that we add a new method instead of overloading matchTemplate in a way that diverges? if that seems reasonable, I can try a pr that pulls the draw rectangle out into another method |
@acinader thanks for the matchTemplate example, i wouldn't know how to make use of the function otherwise. Maybe could be merged to this project so may help others easily |
issue #387