Fix crash in OpenCV::ReadImageAsync #679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix occasional segfault when running examples/readimage.js
roehling
reviewed
Apr 30, 2021
| @@ -37,6 +37,7 @@ class AsyncImDecodeWorker: public Nan::AsyncWorker { | |||
| cv::Mat mbuf(len, 1, CV_64FC1, buf); | |||
| outputmat = cv::imdecode(mbuf, flags); | |||
| success = 1; | |||
| free(buf); | |||
There was a problem hiding this comment.
This will leak memory if an exception is thrown earlier
| Nan::Callback *callback = new Nan::Callback(cb.As<Function>()); | ||
| Nan::AsyncQueueWorker(new AsyncImDecodeWorker(callback, buf, len, flags)); | ||
| Nan::AsyncQueueWorker(new AsyncImDecodeWorker(callback, buf_new, len, flags)); |
There was a problem hiding this comment.
Instead of copying the buffer to mitigate premature garbage collection, it would be better to pass the object itself and make sure that it won't be garbage collected until AsyncImDecodeWorker has completed.
There was a problem hiding this comment.
Okay but i don't know how to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix occasional segfault when running examples/readimage.js