Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 1.58.0 to ~> 1.59.0 #45

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.59

New features

Bug fixes

  • #12434: Fix a false positive for Lint/LiteralAssignmentInCondition when using interpolated string or xstring literals. (@​koic)
  • #12435: Fix a false positive for Lint/SelfAssignment when using attribute assignment with method call with arguments. (@​koic)
  • #12444: Fix false positive for Style/HashEachMethods when receiver literal is not a hash literal. (@​koic)
  • #12524: Fix a false positive for Style/MethodCallWithArgsParentheses when EnforcedStyle: omit_parentheses and parens in when clause is used to pass an argument. (@​koic)
  • #12505: Fix a false positive for Style/RedundantParentheses when using parenthesized lambda or proc with do...end block. (@​koic)
  • #12442: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data as previous loop in do...end and {...} blocks. (@​koic)
  • #12432: Fix a false positive for Lint/LiteralAssignmentInCondition when using parallel assignment with splat operator in block of guard condition. (@​koic)
  • #12441: Fix false positives for Style/HashEachMethods when using destructed block arguments. (@​koic)
  • #12436: Fix false positives for Style/RedundantParentheses when a part of range is a parenthesized condition. (@​koic)
  • #12429: Fix incorrect autocorrect for Style/MapToHash when using dot method calls for to_h. (@​koic)
  • #12488: Make Lint/HashCompareByIdentity aware of safe navigation operator. (@​koic)
  • #12489: Make Lint/NextWithoutAccumulator aware of safe navigation operator. (@​koic)
  • #12490: Make Lint/NumberConversion aware of safe navigation operator. (@​koic)
  • #12491: Make Lint/RedundantWithIndex aware of safe navigation operator. (@​koic)
  • #12492: Make Lint/RedundantWithObject aware of safe navigation operator. (@​koic)
  • #12493: Make Lint/UnmodifiedReduceAccumulator aware of safe navigation operator. (@​koic)
  • #12473: Make Style/ClassCheck aware of safe navigation operator. (@​koic)
  • #12445: Make Style/CollectionCompact aware of safe navigation operator. (@​koic)
  • #12474: Make Style/ConcatArrayLiterals aware of safe navigation operator. (@​koic)
  • #12476: Make Style/DateTime aware of safe navigation operator. (@​koic)
  • #12479: Make Style/EachWithObject aware of safe navigation operator. (@​koic)
  • #12446: Make Style/HashExcept aware of safe navigation operator. (@​koic)
  • #12447: Make Style/MapCompactWithConditionalBlock aware of safe navigation operator. (@​koic)
  • #12484: Make Style/Next aware of safe navigation operator. (@​koic)
  • #12486: Make Style/RedundantArgument aware of safe navigation operator. (@​koic)
  • #12454: Make Style/RedundantFetchBlock aware of safe navigation operator. (@​koic)
  • #12495: Make Layout/RedundantLineBreak aware of safe navigation operator. (@​koic)
  • #12455: Make Style/RedundantSortBy aware of safe navigation operator. (@​koic)
  • #12456: Make Style/RedundantSortBy aware of safe navigation operator. (@​koic)
  • #12480: Make Style/ExactRegexpMatch aware of safe navigation operator. (@​koic)
  • #12457: Make Style/Sample aware of safe navigation operator. (@​koic)
  • #12458: Make Style/SelectByRegexp cops aware of safe navigation operator. (@​koic)
  • #12494: Make Layout/SingleLineBlockChain aware of safe navigation operator. (@​koic)
  • #12461: Make Style/StringChars aware of safe navigation operator. (@​koic)
  • #12468: Make Style/Strip aware of safe navigation operator. (@​koic)
  • #12469: Make Style/UnpackFirst aware of safe navigation operator. (@​koic)

Changes

  • #12522: Make Style/MethodCallWithoutArgsParentheses allow the parenthesized it method in a block. (@​koic)
  • #12523: Make Style/RedundantSelf allow the self.it method in a block. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.59.0 (2023-12-11)

New features

Bug fixes

  • #12434: Fix a false positive for Lint/LiteralAssignmentInCondition when using interpolated string or xstring literals. ([@​koic][])
  • #12435: Fix a false positive for Lint/SelfAssignment when using attribute assignment with method call with arguments. ([@​koic][])
  • #12444: Fix false positive for Style/HashEachMethods when receiver literal is not a hash literal. ([@​koic][])
  • #12524: Fix a false positive for Style/MethodCallWithArgsParentheses when EnforcedStyle: omit_parentheses and parens in when clause is used to pass an argument. ([@​koic][])
  • #12505: Fix a false positive for Style/RedundantParentheses when using parenthesized lambda or proc with do...end block. ([@​koic][])
  • #12442: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data as previous loop in do...end and {...} blocks. ([@​koic][])
  • #12432: Fix a false positive for Lint/LiteralAssignmentInCondition when using parallel assignment with splat operator in block of guard condition. ([@​koic][])
  • #12441: Fix false positives for Style/HashEachMethods when using destructed block arguments. ([@​koic][])
  • #12436: Fix false positives for Style/RedundantParentheses when a part of range is a parenthesized condition. ([@​koic][])
  • #12429: Fix incorrect autocorrect for Style/MapToHash when using dot method calls for to_h. ([@​koic][])
  • #12488: Make Lint/HashCompareByIdentity aware of safe navigation operator. ([@​koic][])
  • #12489: Make Lint/NextWithoutAccumulator aware of safe navigation operator. ([@​koic][])
  • #12490: Make Lint/NumberConversion aware of safe navigation operator. ([@​koic][])
  • #12491: Make Lint/RedundantWithIndex aware of safe navigation operator. ([@​koic][])
  • #12492: Make Lint/RedundantWithObject aware of safe navigation operator. ([@​koic][])
  • #12493: Make Lint/UnmodifiedReduceAccumulator aware of safe navigation operator. ([@​koic][])
  • #12473: Make Style/ClassCheck aware of safe navigation operator. ([@​koic][])
  • #12445: Make Style/CollectionCompact aware of safe navigation operator. ([@​koic][])
  • #12474: Make Style/ConcatArrayLiterals aware of safe navigation operator. ([@​koic][])
  • #12476: Make Style/DateTime aware of safe navigation operator. ([@​koic][])
  • #12479: Make Style/EachWithObject aware of safe navigation operator. ([@​koic][])
  • #12446: Make Style/HashExcept aware of safe navigation operator. ([@​koic][])
  • #12447: Make Style/MapCompactWithConditionalBlock aware of safe navigation operator. ([@​koic][])
  • #12484: Make Style/Next aware of safe navigation operator. ([@​koic][])
  • #12486: Make Style/RedundantArgument aware of safe navigation operator. ([@​koic][])
  • #12454: Make Style/RedundantFetchBlock aware of safe navigation operator. ([@​koic][])
  • #12495: Make Layout/RedundantLineBreak aware of safe navigation operator. ([@​koic][])
  • #12455: Make Style/RedundantSortBy aware of safe navigation operator. ([@​koic][])
  • #12456: Make Style/RedundantSortBy aware of safe navigation operator. ([@​koic][])
  • #12480: Make Style/ExactRegexpMatch aware of safe navigation operator. ([@​koic][])
  • #12457: Make Style/Sample aware of safe navigation operator. ([@​koic][])
  • #12458: Make Style/SelectByRegexp cops aware of safe navigation operator. ([@​koic][])
  • #12494: Make Layout/SingleLineBlockChain aware of safe navigation operator. ([@​koic][])
  • #12461: Make Style/StringChars aware of safe navigation operator. ([@​koic][])
  • #12468: Make Style/Strip aware of safe navigation operator. ([@​koic][])
  • #12469: Make Style/UnpackFirst aware of safe navigation operator. ([@​koic][])

Changes

  • #12522: Make Style/MethodCallWithoutArgsParentheses allow the parenthesized it method in a block. ([@​koic][])
  • #12523: Make Style/RedundantSelf allow the self.it method in a block. ([@​koic][])

... (truncated)

Commits
  • e5a164a Cut 1.59
  • 2912b6e Update Changelog
  • 3bcc171 [Fix #12524] Fix a false positive for Style/MethodCallWithArgsParentheses
  • 0daa4aa Make Style/MethodCallWithoutArgsParentheses allow parenthesized it
  • b240a09 Make Style/RedundantSelf allow self.it
  • a0e1042 [Fix #12526] Fix incorrect rendering typos
  • b1bcb31 [Fix #12444] Fix false positive for Style/HashEachMethods
  • 3b0360b Add new Lint/ItWithoutArgumentsInBlock cop
  • 4e9cfcc Merge pull request #12521 from koic/make_style_select_by_regexp_aware_of_safe...
  • 037c860 Merge pull request #12438 from koic/fix_a_false_positive_for_lint_literal_ass...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.58.0...v1.59.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06800e0) 99.88% compared to head (a175df2) 99.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          15       15           
  Lines        1726     1726           
=======================================
  Hits         1724     1724           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taichi-ishitani taichi-ishitani merged commit f408bd2 into master Dec 12, 2023
8 checks passed
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-tw-1.59.0 branch December 12, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant