Update: Removed use of defaultCLevel function

pistacheio · Nov 12, 2024 · d285317 · d285317
1 parent 2e98845
commit d285317
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/include/pistache/http.h b/include/pistache/http.h
@@ -521,6 +521,8 @@ namespace Pistache
                 return nullptr;
             }
 
+
+
             // Compress using the requested content encoding, if supported,
             //  before sending bits to client. Content-Encoding header will be
             //  automatically set to the requested encoding, if supported...
@@ -535,7 +537,8 @@ namespace Pistache
             }
 #endif
 #ifdef PISTACHE_USE_CONTENT_ENCODING_ZSTD
-
+            // Set the compression level for zstandard algorithm. Defaults to
+            //  ZSTD_CLEVEL_DEFAULT = 3...
             void setCompressionZstdLevel(const int contentEncodingZstdLevel)
             {
                 contentEncodingZstdLevel_ = contentEncodingZstdLevel;
@@ -575,7 +578,9 @@ namespace Pistache
 #endif
 
 #ifdef PISTACHE_USE_CONTENT_ENCODING_ZSTD
-            int contentEncodingZstdLevel_ = ZSTD_defaultCLevel();
+
+            // Value 0 means default, which is controlled by ZSTD_CLEVEL_DEFAULT = 3
+            int contentEncodingZstdLevel_ = 0;
 #endif
 
 #ifdef PISTACHE_USE_CONTENT_ENCODING_DEFLATE

diff --git a/src/common/http.cc b/src/common/http.cc
@@ -933,14 +933,12 @@ namespace Pistache::Http
 #ifdef PISTACHE_USE_CONTENT_ENCODING_ZSTD
 
         case Http::Header::Encoding::Zstd: {
-            // Get max compressed size
             size_t estimated_size = ZSTD_compressBound(size);
             // Allocate a smart buffer to contain compressed data...
             std::unique_ptr compressedData = std::make_unique<std::byte[]>(estimated_size);
 
-            // Compress data using default compression level: https://raw.githack.com/facebook/zstd/release/doc/zstd_manual.html#Chapter3
             auto compress_size = ZSTD_compress(reinterpret_cast<void*>(compressedData.get()), estimated_size,
-                                               data, size, ZSTD_defaultCLevel());
+                                               data, size, contentEncodingZstdLevel_);
             if (ZSTD_isError(compress_size))
             {
                 throw std::runtime_error(

diff --git a/version.txt b/version.txt
@@ -1 +1 @@
-0.4.17.20241110
+0.4.17.20241111