Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean emission factors (#193) #194

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Clean emission factors (#193) #194

merged 4 commits into from
Jul 25, 2024

Conversation

veitu
Copy link
Collaborator

@veitu veitu commented Jun 8, 2024

I removed unnecessary/duplicate emission factor files. I also moved the entire data directory to the Google Drive as it doesn't contain anything that's used in the code. Hope that helps to unclutter the repo a little bit. I'm not sure if the emission factor files under tests/data are needed?

@veitu veitu requested a review from codingfabi June 8, 2024 08:33
@veitu veitu linked an issue Jun 8, 2024 that may be closed by this pull request
Copy link
Collaborator

@han16nah han16nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

Yes, the emission files under tests/data are needed. I think the idea was to keep these fixed for our tests while the actual emission factors in co2calculator/data may be updated if newer data are available.

@codingfabi codingfabi merged commit a05e42b into main Jul 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve/Clearify Emission Factor File Hierarchy
3 participants