fix bug with allowMinimumUploadDuration throwing error

CHANGELOG.md

@@ -1,8 +1,12 @@
 # Changelog
 
+## 4.27.1
+
+-   Fix issue with `allowMinimumUploadDuration` set to `false` throwing error.
+
 ## 4.27.0
 
--   add `allowMinimumUploadDuration` set to `false` to prevent a minimum upload time of 750ms.
+-   Add `allowMinimumUploadDuration` set to `false` to prevent a minimum upload time of 750ms.
 
 ## 4.26.2
 

dist/filepond.css

@@ -1,5 +1,5 @@
 /*!
- * FilePond 4.27.0
+ * FilePond 4.27.1
  * Licensed under MIT, https://opensource.org/licenses/MIT/
  * Please visit https://pqina.nl/filepond/ for details.
  */

dist/filepond.esm.js

@@ -1,5 +1,5 @@
 /*!
- * FilePond 4.27.0
+ * FilePond 4.27.1
  * Licensed under MIT, https://opensource.org/licenses/MIT/
  * Please visit https://pqina.nl/filepond/ for details.
  */
@@ -3213,7 +3213,7 @@ const createPerceivedPerformanceUpdater = (
         timeout = setTimeout(tick, delay);
     };
 
-    tick();
+    if (duration > 0) tick();
 
     return {
         clear: () => {
@@ -3314,7 +3314,10 @@ const createFileProcessor = (processFn, options) => {
                 // we are really done
                 // if perceived progress is 1 ( wait for perceived progress to complete )
                 // or if server does not support progress ( null )
-                if (state.perceivedProgress === 1) {
+                if (
+                    !allowMinimumUploadDuration ||
+                    (allowMinimumUploadDuration && state.perceivedProgress === 1)
+                ) {
                     completeFn();
                 }
             },
@@ -3390,9 +3393,13 @@ const createFileProcessor = (processFn, options) => {
         state.response = null;
     };
 
-    const getProgress = () =>
-        state.progress ? Math.min(state.progress, state.perceivedProgress) : null;
-    const getDuration = () => Math.min(state.duration, state.perceivedDuration);
+    const getProgress = allowMinimumUploadDuration
+        ? () => (state.progress ? Math.min(state.progress, state.perceivedProgress) : null)
+        : () => state.progress || null;
+
+    const getDuration = allowMinimumUploadDuration
+        ? () => Math.min(state.duration, state.perceivedDuration)
+        : () => state.duration;
 
     const api = {
         ...on(),

dist/filepond.js

@@ -1,5 +1,5 @@
 /*!
- * FilePond 4.27.0
+ * FilePond 4.27.1
  * Licensed under MIT, https://opensource.org/licenses/MIT/
  * Please visit https://pqina.nl/filepond/ for details.
  */
@@ -5371,7 +5371,7 @@
             timeout = setTimeout(tick, delay);
         };
 
-        tick();
+        if (duration > 0) tick();
 
         return {
             clear: function clear() {
@@ -5471,7 +5471,10 @@
                     // we are really done
                     // if perceived progress is 1 ( wait for perceived progress to complete )
                     // or if server does not support progress ( null )
-                    if (state.perceivedProgress === 1) {
+                    if (
+                        !allowMinimumUploadDuration ||
+                        (allowMinimumUploadDuration && state.perceivedProgress === 1)
+                    ) {
                         completeFn();
                     }
                 },
@@ -5547,12 +5550,21 @@
             state.response = null;
         };
 
-        var getProgress = function getProgress() {
-            return state.progress ? Math.min(state.progress, state.perceivedProgress) : null;
-        };
-        var getDuration = function getDuration() {
-            return Math.min(state.duration, state.perceivedDuration);
-        };
+        var getProgress = allowMinimumUploadDuration
+            ? function() {
+                  return state.progress ? Math.min(state.progress, state.perceivedProgress) : null;
+              }
+            : function() {
+                  return state.progress || null;
+              };
+
+        var getDuration = allowMinimumUploadDuration
+            ? function() {
+                  return Math.min(state.duration, state.perceivedDuration);
+              }
+            : function() {
+                  return state.duration;
+              };
 
         var api = Object.assign({}, on(), {
             process: process, // start processing file
@@ -7375,7 +7387,6 @@
     var write = function write(_ref2) {
         var root = _ref2.root,
             props = _ref2.props;
-
         if (props.opacity === 0) {
             return;
         }

package.json

@@ -1,6 +1,6 @@
 {
     "name": "filepond",
-    "version": "4.27.0",
+    "version": "4.27.1",
     "description": "FilePond, Where files go to stretch their bits.",
     "license": "MIT",
     "author": {

src/js/app/utils/createFileProcessor.js

@@ -95,7 +95,10 @@ export const createFileProcessor = (processFn, options) => {
                 // we are really done
                 // if perceived progress is 1 ( wait for perceived progress to complete )
                 // or if server does not support progress ( null )
-                if (state.perceivedProgress === 1) {
+                if (
+                    !allowMinimumUploadDuration ||
+                    (allowMinimumUploadDuration && state.perceivedProgress === 1)
+                ) {
                     completeFn();
                 }
             },
@@ -171,9 +174,13 @@ export const createFileProcessor = (processFn, options) => {
         state.response = null;
     };
 
-    const getProgress = () =>
-        state.progress ? Math.min(state.progress, state.perceivedProgress) : null;
-    const getDuration = () => Math.min(state.duration, state.perceivedDuration);
+    const getProgress = allowMinimumUploadDuration
+        ? () => (state.progress ? Math.min(state.progress, state.perceivedProgress) : null)
+        : () => state.progress || null;
+
+    const getDuration = allowMinimumUploadDuration
+        ? () => Math.min(state.duration, state.perceivedDuration)
+        : () => state.duration;
 
     const api = {
         ...on(),

src/js/app/utils/createPerceivedPerformanceUpdater.js

@@ -11,7 +11,6 @@ export const createPerceivedPerformanceUpdater = (
     const start = Date.now();
 
     const tick = () => {
-
         let runtime = Date.now() - start;
         let delay = getRandomNumber(tickMin, tickMax);
 
@@ -30,11 +29,11 @@ export const createPerceivedPerformanceUpdater = (
         timeout = setTimeout(tick, delay);
     };
 
-    tick();
+    if (duration > 0) tick();
 
     return {
         clear: () => {
             clearTimeout(timeout);
-        }
+        },
     };
 };

src/js/app/view/progressIndicator.js

@@ -13,7 +13,7 @@ const create = ({ root, props }) => {
     const svg = createElement('svg');
     root.ref.path = createElement('path', {
         'stroke-width': 2,
-        'stroke-linecap': 'round'
+        'stroke-linecap': 'round',
     });
     svg.appendChild(root.ref.path);
 
@@ -23,7 +23,6 @@ const create = ({ root, props }) => {
 };
 
 const write = ({ root, props }) => {
-
     if (props.opacity === 0) {
         return;
     }
@@ -52,23 +51,13 @@ const write = ({ root, props }) => {
     }
 
     // get arc path
-    const coordinates = percentageArc(
-        size,
-        size,
-        size - ringStrokeWidth,
-        ringFrom,
-        ringTo
-    );
+    const coordinates = percentageArc(size, size, size - ringStrokeWidth, ringFrom, ringTo);
 
     // update progress bar
     attr(root.ref.path, 'd', coordinates);
 
     // hide while contains 0 value
-    attr(
-        root.ref.path,
-        'stroke-opacity',
-        props.spin || props.progress > 0 ? 1 : 0
-    );
+    attr(root.ref.path, 'stroke-opacity', props.spin || props.progress > 0 ? 1 : 0);
 };
 
 export const progressIndicator = createView({
@@ -87,8 +76,8 @@ export const progressIndicator = createView({
                 type: 'spring',
                 stiffness: 0.95,
                 damping: 0.65,
-                mass: 10
-            }
-        }
-    }
+                mass: 10,
+            },
+        },
+    },
 });