Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V11 2 #4549

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

V11 2 #4549

wants to merge 9 commits into from

Conversation

JoviDeCroock
Copy link
Member

No description provided.

Copy link

github-actions bot commented Nov 10, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-11.40ms - +1.58ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +1% (-0.28ms - +0.13ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.41ms - +1.41ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +3% (-0.14ms - +0.47ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +2% (-1.34ms - +1.58ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +5% (-0.11ms - +0.10ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +2% (-0.78ms - +0.59ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +5% (-0.51ms - +1.54ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - -0% (-0.01ms - -0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -5% - +1% (-0.62ms - +0.13ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - -0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +0% (-0.02ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local938.24ms - 945.83ms-unsure 🔍
-1% - +0%
-11.40ms - +1.58ms
preact-main941.68ms - 952.21msunsure 🔍
-0% - +1%
-1.58ms - +11.40ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.27ms - 25.28ms-unsure 🔍
-0% - -0%
-0.01ms - -0.01ms
preact-main25.28ms - 25.28msunsure 🔍
+0% - +0%
+0.01ms - +0.01ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.57ms - 16.61ms-unsure 🔍
-2% - +1%
-0.28ms - +0.13ms
preact-main16.45ms - 16.86msunsure 🔍
-1% - +2%
-0.13ms - +0.28ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.65ms - 1.67ms-unsure 🔍
-2% - +0%
-0.03ms - +0.01ms
preact-main1.66ms - 1.68msunsure 🔍
-0% - +2%
-0.01ms - +0.03ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local71.64ms - 73.21ms-unsure 🔍
-1% - +2%
-0.41ms - +1.41ms
preact-main71.45ms - 72.39msunsure 🔍
-2% - +1%
-1.41ms - +0.41ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local12.68ms - 13.34ms-unsure 🔍
-5% - +1%
-0.62ms - +0.13ms
preact-main13.07ms - 13.43msunsure 🔍
-1% - +5%
-0.13ms - +0.62ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.45ms - 16.98ms-unsure 🔍
-1% - +3%
-0.14ms - +0.47ms
preact-main16.41ms - 16.70msunsure 🔍
-3% - +1%
-0.47ms - +0.14ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.57ms - 4.59ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-main4.58ms - 4.60msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4046
  • Commit: 1218178

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.99ms - 72.97ms-unsure 🔍
-2% - +2%
-1.34ms - +1.58ms
preact-main70.79ms - 72.93msunsure 🔍
-2% - +2%
-1.58ms - +1.34ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.55ms - 3.59ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-main3.57ms - 3.60msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local29.97ms - 30.73ms-unsure 🔍
-2% - +1%
-0.55ms - +0.43ms
preact-main30.10ms - 30.72msunsure 🔍
-1% - +2%
-0.43ms - +0.55ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.80ms - 33.81ms-faster ✔
3% - 8%
1.18ms - 2.93ms
preact-main34.64ms - 36.07msslower ❌
3% - 9%
1.18ms - 2.93ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local24.12ms - 24.56ms-unsure 🔍
-2% - +1%
-0.51ms - +0.15ms
preact-main24.28ms - 24.76msunsure 🔍
-1% - +2%
-0.15ms - +0.51ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.61ms - 28.22ms-unsure 🔍
-3% - +5%
-0.93ms - +1.27ms
preact-main26.50ms - 28.00msunsure 🔍
-5% - +3%
-1.27ms - +0.93ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local19.44ms - 20.02ms-unsure 🔍
-2% - +2%
-0.40ms - +0.38ms
preact-main19.48ms - 20.00msunsure 🔍
-2% - +2%
-0.38ms - +0.40ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.56ms - 22.21ms-unsure 🔍
-2% - +2%
-0.45ms - +0.40ms
preact-main21.64ms - 22.19msunsure 🔍
-2% - +2%
-0.40ms - +0.45ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 170
  • Built by: CI #4046
  • Commit: 1218178

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.15ms - 2.28ms-unsure 🔍
-5% - +5%
-0.11ms - +0.10ms
preact-main2.14ms - 2.30msunsure 🔍
-5% - +5%
-0.10ms - +0.11ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.10ms - 1.11ms-unsure 🔍
-1% - -0%
-0.01ms - +0.00ms
preact-main1.11ms - 1.11msunsure 🔍
-0% - +1%
-0.00ms - +0.01ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.32ms - 34.76ms-unsure 🔍
-2% - +2%
-0.78ms - +0.59ms
preact-main33.99ms - 35.28msunsure 🔍
-2% - +2%
-0.59ms - +0.78ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.21ms - 1.24ms-unsure 🔍
-1% - +1%
-0.02ms - +0.01ms
preact-main1.22ms - 1.23msunsure 🔍
-1% - +1%
-0.01ms - +0.02ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.18ms - 34.68ms-unsure 🔍
-2% - +5%
-0.51ms - +1.54ms
preact-main32.72ms - 34.11msunsure 🔍
-5% - +1%
-1.54ms - +0.51ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.50ms - 3.53ms-unsure 🔍
-1% - +0%
-0.02ms - +0.00ms
preact-main3.52ms - 3.53msunsure 🔍
-0% - +1%
-0.00ms - +0.02ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Nov 10, 2024

Size Change: -1.64 kB (-2.63%)

Total Size: 60.6 kB

Filename Size Change
compat/dist/compat.js 3.79 kB -343 B (-8.31%)
compat/dist/compat.module.js 3.71 kB -350 B (-8.62%)
compat/dist/compat.umd.js 3.84 kB -351 B (-8.37%)
debug/dist/debug.js 3.82 kB -5 B (-0.13%)
debug/dist/debug.module.js 3.82 kB -5 B (-0.13%)
debug/dist/debug.umd.js 3.9 kB -6 B (-0.15%)
dist/preact.js 4.59 kB -102 B (-2.17%)
dist/preact.min.js 4.62 kB -92 B (-1.95%)
dist/preact.min.module.js 4.62 kB -104 B (-2.2%)
dist/preact.min.umd.js 4.65 kB -89 B (-1.88%)
dist/preact.module.js 4.61 kB -101 B (-2.14%)
dist/preact.umd.js 4.67 kB -88 B (-1.85%)
ℹ️ View Unchanged
Filename Size
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 976 B
jsx-runtime/dist/jsxRuntime.module.js 949 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Nov 10, 2024

Coverage Status

coverage: 99.465% (-0.02%) from 99.486%
when pulling 1218178 on v11-2
into 514183f on main.

@rschristian
Copy link
Member

#4406 would be another easy thing to fit in, swapping out our (pretty much unused & problematic) package.json##browser condition for package.json##module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants