Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ray support functions to handle ray job api operation using tls check verification for insecure cluster #61

Merged

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Aug 20, 2024

Issue link

What changes have been made

  • Updated ray job support functions to handle ray job api operations using tls check
  • Added functions for asserting ray job status

Verification steps

Manually

image

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@abhijeet-dhumal abhijeet-dhumal changed the title Update ray utils functions to handle ray job api operation using tls … Update ray support functions to handle ray job api operation using tls check verification for insecure cluster Aug 21, 2024
…rification and added functions for asserting ray job status
support/ray_cluster_client.go Outdated Show resolved Hide resolved
support/ray_cluster_client.go Outdated Show resolved Hide resolved
support/ray_cluster_client.go Outdated Show resolved Hide resolved
…tConfig and removed waitForJobStatus function
@sutaakar
Copy link
Contributor

/lgtm

Copy link
Collaborator

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal, astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9234d23 into project-codeflare:main Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants