solara: Add virus_on_network network example #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rht
commented
Aug 17, 2023
rht
force-pushed
the
network
branch
2 times, most recently
from
9592ab8
to
67bfde6
Compare
rht
changed the title
|
This is ready to merge. |
Corvince
reviewed
Sep 26, 2023
|
|
||
| width = [] # edge width | ||
| edge_color = [] | ||
| for u, v in graph.edges(): |
There was a problem hiding this comment.
u, v, w and ec are quite not-descriptive. Maybe call it edge_width, edge_color here and above edge_colorss and edge_widths ?
There was a problem hiding this comment.
edge_color in NetworkX is a list of edge colors. As much as this is confusing, I have to stay consistent with NetworkX. Ditto with the plural for edge_width.
u, v should be fine for undirected graph, just like i, j for 2D grid.
There was a problem hiding this comment.
See edge_color in https://networkx.org/documentation/stable/reference/generated/networkx.drawing.nx_pylab.draw_networkx.html, which may be a scalar or vector.
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting until projectmesa/mesa#1767 is merged and we have a release.