Add configuration for keeping original labels in mappings #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
rabenhorst
force-pushed
the
mapping-honor-labels
branch
from
08085ac
to
4392bea
Compare
|
Awesome, thank you! |
matthiasr
added a commit
that referenced
this pull request
Dec 6, 2023
with documentation for #521 and changelog. Signed-off-by: Matthias Rampke <matthias@prometheus.io>
matthiasr
added a commit
to prometheus/graphite_exporter
that referenced
this pull request
Dec 6, 2023
and some others that `go get -u` pulled in. This brings in the `honor_labels` support from prometheus/statsd_exporter#521.
matthiasr
added a commit
to prometheus/graphite_exporter
that referenced
this pull request
Dec 6, 2023
and some others that `go get -u` pulled in. This brings in the `honor_labels` support from prometheus/statsd_exporter#521. Signed-off-by: Matthias Rampke <matthias@prometheus.io>
matthiasr
added a commit
to prometheus/graphite_exporter
that referenced
this pull request
Dec 6, 2023
and some others that `go get -u` pulled in. This brings in the `honor_labels` support from prometheus/statsd_exporter#521. Signed-off-by: Matthias Rampke <matthias@prometheus.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a label is assigned in mappings that already exists, it will be replaced. This PR introduces a
honor_labelsparameter. When this parameter is set to true, it will preserve the original value of the label.