Change to use the waiting tasks in the filter for task metrics. #5985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #5941 After some discussion we decided to use the task status in the filter that search for unblocked tasks in the queue. This can avoid a situation where tasks have the `unblocked_at` field filled yet they are not waiting in the queue anymore.
decko
force-pushed
the
update_task_metrics_query
branch
from
13cdaf4
to
7a5d9e0
Compare
ggainey
approved these changes
Nov 7, 2024
Backport to 3.63: 💚 backport PR created✅ Backport PR branch: Backported as #6017 🤖 @patchback |
Backport to 3.67: 💚 backport PR created✅ Backport PR branch: Backported as #6018 🤖 @patchback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5941
After some discussion we decided to use the task status in the filter
that search for unblocked tasks in the queue. This can avoid a situation
where tasks have the
unblocked_atfield filled yet they are notwaiting in the queue anymore.