Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump upperversion of protobuf to allow Protobuf v5. #6039

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

decko
Copy link
Member

@decko decko commented Nov 19, 2024

The new opentelemetry dependencies started to use protobuf 5
and dropped support to protobuf 4. This commit allow protobuf 5
to be installed when it's needed.

This PR is related to #6037

[noissue]

The new `opentelemetry` dependencies started to use protobuf 5
and dropped support to protobuf 4. This commit allow protobuf 5
to be installed when it's needed.

[noissue]
@ggainey
Copy link
Contributor

ggainey commented Nov 19, 2024

maybe reopen #5789 instead, so dependabot unignores protobuf again?

@mdellweg
Copy link
Member

I think these two dependencies are depending rigidly on each other. So #5789 was blocked on #6037 and the other way around.

@decko
Copy link
Member Author

decko commented Nov 19, 2024

maybe reopen #5789 instead, so dependabot unignores protobuf again?
Good catch @ggainey

I think these two dependencies are depending rigidly on each other. So #5789 was blocked on #6037 and the other way around.

Yeah, and given that I believe won't be possible to re-open #5789 to uningnore protobuf this time @ggainey. Thanks for the rational about it @mdellweg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants