Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Qt 6.7.1 #403

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

OPNA2608
Copy link
Contributor

Upstream QTBUG-105023 fix made it mandatory that arguments to QObject::findChild[ren] calls must be Q_OBJECTs.

Fixes FTBFS with Qt 6.7.1:

[ 89%] Building CXX object src/CMakeFiles/punes.dir/gui/dlgStdPad.cpp.o
In file included from /nix/store/ikqvl8jq0d7vlp25d9zlbh44m4hljahc-qtbase-6.7.1/include/QtCore/qiodevice.h:10,
                 from /nix/store/ikqvl8jq0d7vlp25d9zlbh44m4hljahc-qtbase-6.7.1/include/QtCore/qbuffer.h:7,
                 from /nix/store/ikqvl8jq0d7vlp25d9zlbh44m4hljahc-qtbase-6.7.1/include/QtCore/QBuffer:1,
                 from /build/source/src/gui/dlgStdPad.cpp:19:
/nix/store/ikqvl8jq0d7vlp25d9zlbh44m4hljahc-qtbase-6.7.1/include/QtCore/qobject.h: In instantiation of 'T QObject::findChild(QAnyStringView, Qt::FindChildOptions) const [with T = pixmapButton*; Qt::FindChildOptions = QFlags<Qt::FindChildOption>]':
/build/source/src/gui/dlgStdPad.cpp:99:35:   required from here
/nix/store/ikqvl8jq0d7vlp25d9zlbh44m4hljahc-qtbase-6.7.1/include/QtCore/qobject.h:151:62: error: static assertion failed: No Q_OBJECT in the class passed to QObject::findChild
  151 |         static_assert(QtPrivate::HasQ_OBJECT_Macro<ObjType>::Value,
      |                                                              ^~~~~
/nix/store/ikqvl8jq0d7vlp25d9zlbh44m4hljahc-qtbase-6.7.1/include/QtCore/qobject.h:151:62: note: 'QtPrivate::HasQ_OBJECT_Macro<pixmapButton>::Value' evaluates to false
make[2]: *** [src/CMakeFiles/punes.dir/build.make:7505: src/CMakeFiles/punes.dir/gui/dlgStdPad.cpp.o] Error 1

Upstream QTBUG-105023 fix made it mandatory that arguments to QObject::findChild[ren] calls must be Q_OBJECTs.
@punesemu
Copy link
Owner

Thanks so much for the patch. I'm away from home for a few days but I'll come back over the weekend and take a look at your request.

@punesemu punesemu merged commit 6e51b1a into punesemu:master May 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants