(PDB-5696) query.monitor/stop: elaborate on interrupt considerations

puppetlabs · Sep 5, 2023 · 173dd07 · 173dd07
1 parent 579aeb2
commit 173dd07
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/puppetlabs/puppetdb/query/monitor.clj b/src/puppetlabs/puppetdb/query/monitor.clj
@@ -321,7 +321,10 @@
      (do
        (reset! exit true)
        (.wakeup selector)
-       ;; Q: do we want this, and if so, have thread swallow it on the way out?
+       ;; Q: do we want this, and if so, have thread swallow it on the
+       ;; way out?  Before deciding, see the SelectableChannel docs.
+       ;; Thread interrupts cause the key for any channel the thread
+       ;; was blocked on to be canceled.
        ;; (.interrupt monitor-thread)
        (if timeout-ms
          (.join thread timeout-ms)