(PDB-5663) Sync version +1 to improve sync request timeout handling #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
One way we might handle it. |
rbrw
force-pushed
the
pdb-5663-improve-timeout-sync-request-responses
branch
2 times, most recently
from
e3693fb
to
dc5c203
Compare
Increment the sync version so that sync requests from newer servers that specify a query timeout will receive a more meaningful message that indicates the version mismatch, rather than a more generic crash on an unexpected parameter.
rbrw
force-pushed
the
pdb-5663-improve-timeout-sync-request-responses
branch
from
857ae27
to
0ef376a
Compare
austb
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increment the sync version so that sync requests from newer servers that specify a query timeout will receive a more meaningful message that indicates the version mismatch, rather than a more generic crash on an unexpected parameter.