Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Fix progressing-timestamp to progress #3857

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

jpartlow
Copy link
Contributor

The progressing-timestamp was being called with each update-host, regenerating the function each time with a base value. This ensures that we generate the function once so it can progress.

Also changed the default end-command-in days to 0 so that for cases where adding historical reports should take only minutes or hours don't end up shifted forward 7 days by default.

The progressing-timestamp was being called with each update-host,
regenerating the function each time with a base value. This ensures that
we generate the function once so it can progress.

Also changed the default end-command-in days to 0 so that for cases
where adding historical reports should take only minutes or hours don't
end up shifted forward 7 days by default.
@jpartlow jpartlow requested review from a team as code owners August 16, 2023 16:36
Copy link
Contributor

@rbrw rbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@jpartlow
Copy link
Contributor Author

Failures are a query monitoring timing issue and rhel9 platform which is work in progress.

@jpartlow jpartlow merged commit 203894c into puppetlabs:main Aug 16, 2023
8 of 9 checks passed
@jpartlow jpartlow deleted the maint-fix-progressing-timestamp branch August 16, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants