Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several minor build issues #782

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Fix several minor build issues #782

merged 5 commits into from
Aug 4, 2023

Conversation

kbattocchi
Copy link
Collaborator

@kbattocchi kbattocchi commented Jun 16, 2023

This fixes a few build issues:

  • Our nightly builds have been failing due in part to failure to properly handle the use_lkg flag in sub-workflows due to string/boolean conversions in GitHub Actions
  • joblib 1.3 is not compatible with Python 3.7 on Windows
  • Our package metadata includes compatible Python versions in human readable "classifier" form, but not the "requires-python" form used by tools like pip; I've addressed this by adding this field to pyproject.toml and migrating the rest of the package metadata there from setup.cfg
  • We can support the new dowhy 0.10 release
  • A new pycodestyle release has resulted in some new lint issues due to changes in some corner cases

@kbattocchi kbattocchi force-pushed the kebatt/improveCI branch 4 times, most recently from 81000ae to 4dd6eed Compare July 8, 2023 07:37
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
@kbattocchi kbattocchi force-pushed the kebatt/improveCI branch 2 times, most recently from fcd841a to fe281b7 Compare August 3, 2023 15:39
@kbattocchi kbattocchi changed the title Add LKG generation to CI Fix several minor build issues Aug 3, 2023
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
@kbattocchi kbattocchi requested a review from fverac August 3, 2023 16:01
@kbattocchi kbattocchi marked this pull request as ready for review August 3, 2023 16:01
pyproject.toml Show resolved Hide resolved
@kbattocchi kbattocchi merged commit de4f05d into main Aug 4, 2023
65 checks passed
@kbattocchi kbattocchi deleted the kebatt/improveCI branch August 4, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants