Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling ortholearners using Ray #800

Merged
merged 19 commits into from
Oct 27, 2023
Merged

Scaling ortholearners using Ray #800

merged 19 commits into from
Oct 27, 2023

Commits on Aug 2, 2023

  1. Update _ortho_learner.py 

    Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1128981 View commit details
    Browse the repository at this point in the history

  2. added ray args dml.py 

    Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d5af162 View commit details
    Browse the repository at this point in the history

  3. Update _rlearner.py 

    Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    bb772c2 View commit details
    Browse the repository at this point in the history

  4. Update test_ortho_learner.py 

    Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9b7540d View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Update setup.cfg added ray dependencies 

    Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e1d3aba View commit details
    Browse the repository at this point in the history

  2. Fixed linting issue in test_ortho_learner.py 

    Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b10c804 View commit details
    Browse the repository at this point in the history

  3. Update ci.yml added Ray in extras 

    Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    274e788 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Merge remote-tracking branch 'upstream/main' into scaling_ortholearners 

    # Conflicts:
#	setup.cfg
    @v-shaal
    v-shaal committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b190e8f View commit details
    Browse the repository at this point in the history

  2. What have been fixed since last commit ? 

    1) Fixed ci.yml extras dependencies
2) Added Description of all the added option in doc string in case of dml and rlearner
3) Addressed chaneges suggested for _ortho_learner.py
4)Removed ray.shutdown(), it can be taken care of explicitly on case to case basis .
5)Made ray_remote_func_options as explicit dictionary argument.

What has been added ?
1) Extended the changes to all estimators using _crossfit.
2) Added Test case to run for with_ray and without_ray for above changes
3) Added Notebook on how to use this feature.

Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    eae67fd View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Fixed Notebook test for new notebook, and default to use_ray=False in… 

    … testcases

Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f09f2e3 View commit details
    Browse the repository at this point in the history

  2. set cpu to 1 for ray , to avoid OOM error while running ray in local … 

    …mode for tests.

Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6d81b37 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. -updated spacing issue in docstring 

    -removed redundant code for ray_remote_function and moved to ortholearner's fit

Signed-off-by: Vishal Verma <vishalmverma27@gmail.com>
    @v-shaal
    v-shaal committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    f877ae0 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge branch 'main' into scaling_ortholearners 

    Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
    @kbattocchi
    kbattocchi committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    d28199f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Split ray tests into new mark 

    Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
    @kbattocchi
    kbattocchi committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3c2eb4b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into scaling_ortholearners 

    Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
    @kbattocchi
    kbattocchi committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3289831 View commit details
    Browse the repository at this point in the history

  3. Fixup test driv 

    Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
    @kbattocchi
    kbattocchi committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    b67bdab View commit details
    Browse the repository at this point in the history

  4. Fix spacing in ortholearner docstring 

    Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
    @kbattocchi
    kbattocchi committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d97b132 View commit details
    Browse the repository at this point in the history

  5. Make tests more robust 

    Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
    @kbattocchi
    kbattocchi committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    57b78b1 View commit details
    Browse the repository at this point in the history

  6. Fixup OrthoLearner docstring 

    Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
    @kbattocchi
    kbattocchi committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    9fbbe7d View commit details
    Browse the repository at this point in the history