Use SemiNorm #325
Merged
Use SemiNorm #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release of SymPDE provides the SemiNorm class.
|
This PR appears to be blocked by #321, which should take precedence. |
yguclu
reviewed
Aug 30, 2023
yguclu
reviewed
Aug 30, 2023
yguclu
approved these changes
Aug 31, 2023
campospinto
pushed a commit
that referenced
this pull request
Oct 6, 2023
Use H^1 and H^2 `SemiNorm` from SymPDE. Previously the class `Norm` was used for all seminorms, which was not mathematically correct. --------- Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use H^1 and H^2
SemiNormfrom SymPDE. Previously the classNormwas used for all seminorms, which was not mathematically correct.