Introduce 'best deep match' heuristic #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also print a small hint that `--verbose` should be used to try to see all errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also print a small hint that
--verboseshould be used to try to see all errors.Tests are just tweaked a little to catch this in the output, but a sample of the new rendering...
Hopefully, this can guide people towards
--verbosemore often when they need it, and the "best deep match" might surface better things for certain schemas. The whole space of guessing which error to show is kind of dicey though -- I tried various priorities for different validators and found that it always depends on how the schema was written.