Make logback access logging work with Jetty 12 #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiefermat
force-pushed
the
logback_jetty12
branch
4 times, most recently
from
f58effd
to
eb3a88b
Compare
kiefermat
force-pushed
the
logback_jetty12
branch
from
eb3a88b
to
a200351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the ServerAdapter class in logback-access to completely encapsulate the request and response objects. The AccessEvent then only uses the ServerAdapter to get the necessary data from the request and response objects. This allows for a separate implementation for jetty 12 where the Request and the Response class do no longer inherit from HttpServletRequest and HttpServletResponse.
Fixes #719