Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: R55 crate error handling #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: R55 crate error handling #13

wants to merge 4 commits into from
+200 −88

Conversation

0xurb
Copy link
Contributor

@0xurb 0xurb commented Nov 14, 2024 •
edited
Loading

  • r55 crate
  • syscalls crate
  • interpreter crate

leonardoalt
leonardoalt reviewed Nov 15, 2024
View reviewed changes
r55/Cargo.toml
eth-riscv-interpreter.workspace = true
eth-riscv-syscalls.workspace = true

revm = "9.0.0"
#revm = { git = "https://github.com/r0qs/revm" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this actually

leonardoalt
leonardoalt reviewed Nov 15, 2024
View reviewed changes
r55/Cargo.toml
eth-riscv-interpreter.workspace = true
eth-riscv-syscalls.workspace = true

revm = "9.0.0"
#revm = { git = "https://github.com/r0qs/revm" }
revm = { version = "9.0.0", features = ["std"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need std?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for error conversion

leonardoalt
leonardoalt reviewed Nov 15, 2024
View reviewed changes
r55/src/error.rs
RvEmuException(Exception),
/// EVM error
#[error(transparent)]
EvmError(#[from] EVMError<DB::Error>),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do we use this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on evm transact we use EVM error, exception is on getting dram slice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardoalt leonardoalt leonardoalt left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xurb @leonardoalt