Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app store deep links in dapp browser #6267

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Fix app store deep links in dapp browser #6267

merged 4 commits into from
Nov 18, 2024
+35 −39

Conversation

maxbbb
Copy link
Contributor

@maxbbb maxbbb commented Nov 15, 2024 •
edited
Loading

Fixes APP-1833

What changed (plus any additional context for devs)

  • handleOnOpenWindow checks if url is app store link and prevents browser navigation if so, opening the link natively instead
  • consolidated url protocol prefix validation logic

This does not handle

  • if the user directly inputs an app store link to the address bar, as this would require more extensive changes and is a very unlikely user behavior
  • specific app deep link schemes (e.g metamask://route)

Screen recordings / screenshots

RPReplay_Final1731628405.mov

What to test

on iOS, must test on physical device.

@linear Linear
Copy link

linear bot commented Nov 15, 2024

APP-1833 Deep link redirect failure on RainbowKit Get flow

@brunobar79
Copy link
Member

Launch in simulator or device for c51c5ef

@brunobar79 brunobar79 requested review from walmat and removed request for brunobar79 November 18, 2024 19:54
walmat
walmat approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm one cleanup comment

src/components/DappBrowser/search/Search.tsx Outdated Show resolved Hide resolved
@brunobar79
Copy link
Member

Launch in simulator or device for 1f7f9b9

christianbaroni
christianbaroni approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@christianbaroni christianbaroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@maxbbb maxbbb merged commit 3324ea5 into develop Nov 18, 2024
8 checks passed
@maxbbb maxbbb deleted the @kane/APP-1833 branch November 18, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianbaroni christianbaroni christianbaroni approved these changes

@walmat walmat walmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxbbb @brunobar79 @walmat @christianbaroni