Recreate job always if generation has changed #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulcabello
force-pushed
the
gitjob-update-bug
branch
2 times, most recently
from
3bc2b36
to
fda1f18
Compare
raulcabello
changed the title
Co-authored-by: Corentin Néau <tan.neau@suse.com> Co-authored-by: Xavi Garcia <xavi.garcia@suse.com>
raulcabello
force-pushed
the
gitjob-update-bug
branch
from
5451c6f
to
e462e07
Compare
weyfonk
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the k8s
Jobif theGitJobgeneration has changed. This deletion will trigger a reconciliation loop, and a new k8sJobwill be created. k8sJobsare immutable, so we need to delete and recreate.Don't use retry if there is a conflict error when updating the
GitJobStatus. This was updating theObservedGenerationwhen it shouldn't . UseRequeueinstead of retry.e2e in fleet with this version are passing rancher/fleet#2080
refers to #415