feat(PT-3255): update approval on bid execution #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakischik
reviewed
Aug 1, 2023
| } | ||
| val assetType = sideDto.asset.assetType | ||
| if (assetType is Erc20AssetTypeDto) { | ||
| logger.info("Will recalculate erc20 balance") |
There was a problem hiding this comment.
Provide more info in logs - which balance, from what order etc
| ) : RaribleKafkaEventHandler<EthActivityEventDto> { | ||
|
|
||
| override suspend fun handle(event: EthActivityEventDto) { | ||
| logger.info("Handle event: $event") |
There was a problem hiding this comment.
I think there is no sense to track all events, only those we are interested in
There was a problem hiding this comment.
how do we track if something is missed?
There was a problem hiding this comment.
reduced amount of logs
yakischik
approved these changes
Aug 1, 2023
dmitry-saraykin
deleted the
feature/PT-3255-update-approval-on-bid-execution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.