feat: PT-3542 Add api call count metrics #718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukata-sa
approved these changes
Aug 7, 2023
| @@ -23,6 +22,17 @@ class ForeignOrderMetrics( | |||
| registerLatestOrderGauge() | |||
| } | |||
|
|
|||
| fun onCallForeignOrderApi(platform: Platform, status: ApiCallStatus) { | |||
There was a problem hiding this comment.
Maybe we can add some operationId/uri here? This counter may be helpful in general to track external requests, but if specify only platform and no operationId it is less helpful
| @@ -68,8 +72,14 @@ class LooksrareOrderService( | |||
|
|
|||
| while (retries.get() < properties.retry) { | |||
| when (val result = looksrareClient.getOrders(request)) { | |||
There was a problem hiding this comment.
It is probably better to make a wrapper for looksrareClient like we do for ethereum client. the same for x2y2. It will allow to not miss metrics if the client is used somewhere else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.