Schema4.5 #57
Open
Schema4.5 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add a couple of details.
Checking for a syntax problem - but could not find any. The build from the first file I sent looks good, i.e. no errors. This branch includes those changes.
Trying to fix rst errors. Many lines with blanks on the end, lines too long, bad targets. It seems there must be a space before the url in links.
Trying to fix too long lines and trailing blanks...
|
Looks like all checks have passed! |
Open
RKrahl
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Normally, it is best practice to clearly separate the roles: one proposes changes, another one reviews the proposal. But here, my review need to go deep into technical and formal details, including reStructuredText syntax errors. In this case, it is much easier to do the changes myself right away, rather than to explain them verbally.
Therefore, I submitted another PR #59 to amend your proposal. See that PR for a detailed list of changes. You may review the change in the rendered results by comparing your version with the updated version. @tedhabermann, please let me know if you are happy with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the build from the last metadata.rst file and it looked fine. I thought one of the links might be bad, but I tested them all. I made a couple of other changes in this branch, adding to the originals.