Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development/json number type #1382

Closed
wants to merge 49 commits into from
Closed

Conversation

msieben
Copy link
Contributor

@msieben msieben commented Jul 28, 2023

Amend 1381.

pwielders and others added 24 commits July 7, 2023 22:33
…f possible.

In case the JSONRPC message reeived is malformatted, Thunder should try to return
a JSONRPC error on malformatted JSON message in stead of:
1) Not responding at all.
2) Send an Web Error status even if the ID was sxtracted from the message.

These fixes are related to: METROL-802/METROL-803
Starting or ending of an opaque structure should *only* contain white spaces. Anything
else should be considered something to be parsed..
…earlier.

In the mean time also prevented quoted areas from being accounted in the cope counting and in case we are
deserializing in opaque areas drop the white space for further processing and storage.
…well..

Checking the validity of the JSONRPC messages coming in over the websockets. If incorrect, rturn an error if possible.
Empty (opaque) strings should be quoted if enabled.
See issues:

- METROL-779

- METROL 780

 -METROL-781

- METROL-782

- METROL-795

- METROL-796

- METROL-797
Fall through from the previous case label is intentional.
@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Thunder/1382/rdkcentral/Thunder

  • Commit: 889bb77

Report detail: gist

…N parsing for NumberType<>

 Update 'test_jsonnumbertype.cpp' with matching test cases
@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Thunder/1382/rdkcentral/Thunder

  • Commit: 1165107

Report detail: gist

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Thunder/1382/rdkcentral/Thunder

  • Commit: 1165107

Report detail: gist

@rdkcmf-jenkins
Copy link

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: spurious

  • Commit: 1165107

msieben and others added 3 commits August 18, 2023 09:04
… a few warnings (#1395)

* Adding pedantic warnings to Thunder, treating all warnings as errors, fixing some warnings from an older GCC version

* Adding pedantic warnings to the project.cmake.in as well

* Properly disabling one test that fails and needs to be fixed

* Removing wpedantic werror from project.cmake.in to stop other modules from inheriting it
@msieben
Copy link
Contributor Author

msieben commented Oct 20, 2023

Superseded by #1433

@msieben msieben closed this Oct 20, 2023
@pwielders pwielders deleted the development/JSONNumberType branch October 24, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants