Skip to content

Commit

Permalink
Merge pull request #5 from recca0120/analysis-qM51Kv
Browse files Browse the repository at this point in the history
Apply fixes from StyleCI
  • Loading branch information
recca0120 authored Feb 9, 2018
2 parents 0598047 + 4e0bdf6 commit 113f380
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/Point.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function isEmpty()
* @param string $operator
* @return bool
*/
public function compare(Point $point, $operator = '=')
public function compare(self $point, $operator = '=')
{
$sum = $this->x * 10 + $this->y;
$sum2 = $point->x * 10 + $point->y;
Expand Down
2 changes: 1 addition & 1 deletion tests/Moskytw/DirectoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function test_find()
$this->assertSame('100', $this->directory->find('臺北市中正區中華路1段48號'));
$this->assertSame('10010', $this->directory->find('臺北市中正區中華路1段49號'));

// 10010,臺北市,中正區,中華路1段,  49號
// 10010,臺北市,中正區,中華路1段,  49號
$this->assertSame('100', $this->directory->find('臺北市中正區中華路1段48號'));
$this->assertSame('10010', $this->directory->find('臺北市中正區中華路1段49號'));
$this->assertSame('100', $this->directory->find('臺北市中正區中華路1段50號'));
Expand Down
1 change: 0 additions & 1 deletion tests/RuleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
use Mockery as m;
use Recca0120\Twzipcode\Rule;
use PHPUnit\Framework\TestCase;
use Recca0120\Twzipcode\Address;

class RuleTest extends TestCase
{
Expand Down
4 changes: 2 additions & 2 deletions tests/RulesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function testMatch()
$this->assertSame('100', $this->rules->match('臺北市中正區中華路1段48號'));
$this->assertSame('10010', $this->rules->match('臺北市中正區中華路1段49號'));

// 10010,臺北市,中正區,中華路1段,  49號
// 10010,臺北市,中正區,中華路1段,  49號
$this->assertSame('100', $this->rules->match('臺北市中正區中華路1段48號'));
$this->assertSame('10010', $this->rules->match('臺北市中正區中華路1段49號'));
$this->assertSame('100', $this->rules->match('臺北市中正區中華路1段50號'));
Expand Down Expand Up @@ -325,7 +325,7 @@ public function testZip3North()
$this->assertSame('654', $rules->match('雲林縣四湖鄉'.uniqid()));
$this->assertSame('655', $rules->match('雲林縣元長鄉'.uniqid()));

// $this->assertSame('600', $rules->match('嘉義市'.uniqid()));
// $this->assertSame('600', $rules->match('嘉義市'.uniqid()));
$this->assertSame('602', $rules->match('嘉義縣番路鄉'.uniqid()));
$this->assertSame('603', $rules->match('嘉義縣梅山鄉'.uniqid()));
$this->assertSame('604', $rules->match('嘉義縣竹崎鄉'.uniqid()));
Expand Down

0 comments on commit 113f380

Please sign in to comment.