Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved treatment of doubling / halving time when growth rate estimate spans 0 #94

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Commits on Dec 12, 2018

  1. Configuration menu
    Copy the full SHA
    f7502e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. Configuration menu
    Copy the full SHA
    386c73c View commit details
    Browse the repository at this point in the history
  2. passes my tests for reconhub#28, but breaks other tests (on first run…

    … of tests()) and regenerates reference files; passes all tests on second run of tests(); not committing new reference files
    jrcpulliam committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    3acefbc View commit details
    Browse the repository at this point in the history
  3. change all occurrences of expect_equal_to_reference() to expect_known…

    …_value() with update=FALSE; note that there is a bug in expect_equal_to_reference() such that update is reset from FALSE to TRUE (see testthat issue 683)
    jrcpulliam committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    134b0c5 View commit details
    Browse the repository at this point in the history
  4. updating test for handling groups for r estimates with different sign…

    …s; need input from @thibautjombart on what expected behavior should be
    jrcpulliam committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    07cabe2 View commit details
    Browse the repository at this point in the history
  5. have reviewed errors and confirmed that the new values reflect the de…

    …sired behaviour as a result of the change to doubling / halving interval CIs; committing new reference rds files
    jrcpulliam committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    a551b86 View commit details
    Browse the repository at this point in the history
  6. throw error if growth rates for groups have different signs but are f…

    …it together; add test for this
    jrcpulliam committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    0a7cf4b View commit details
    Browse the repository at this point in the history
  7. adjust data generation for some automated tests so not relying on gro…

    …ups that have growth rates with different signs
    jrcpulliam committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    0549b31 View commit details
    Browse the repository at this point in the history
  8. regenerate reference fits due to change in data used to generate the …

    …fits (see previous commit)
    jrcpulliam committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    475f27a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7422cce View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bbda47f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d404478 View commit details
    Browse the repository at this point in the history