Updated references for OpenShift 'master' to 'control plane node' #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whowutwut
reviewed
Feb 12, 2022
docs/bmquickstart.md
Outdated
| @@ -141,12 +141,12 @@ Create the installation manifests | |||
| openshift-install create manifests | |||
| ``` | |||
|
|
|||
| Edit the `manifests/cluster-scheduler-02-config.yml` Kubernetes manifest file to prevent Pods from being scheduled on the control plane machines by setting `mastersSchedulable` to `false`. | |||
| Edit the `manifests/cluster-scheduler-02-config.yml` Kubernetes manifest file to prevent Pods from being scheduled on the control plane machines by setting `controlplaneSchedulable` to `false`. | |||
There was a problem hiding this comment.
Is this a spec change that has happened in the latest OpenShift? I think the spec name is mastersSchedulable
spec:
mastersSchedulable: false
...
same comment applies to the other lines changed in this file.
There was a problem hiding this comment.
@whowutwut oversight on my part. Reverted back to mastersSchedulable.
|
Sorry, I am blocked from testing any PRs until this issue is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed references from master to control plane node (or just control plane) WRT OpenShift. Fix #274