Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: problems moving network devices with Carry On mod #492

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

raoulvdberge
Copy link
Contributor

Carry On was initializing block entities twice.
We had to:

  • Protect the event queue from running the update for the first erroneous initialization request.
  • Allow block entity removals without network, to avoid a crash when the block entity is replaced. The event queue hasn't run yet at that point so there's no network, so allow no networks on removal.

Fixes #456

Carry On was initializing block entities twice.
We had to:

* Protect the event queue from running the update for the first erroneous initialization request.
* Allow block entity removals without network, to avoid a crash when the block entity is replaced.
The event queue hasn't run yet at that point so there's no network, so allow no networks on removal.
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@raoulvdberge raoulvdberge merged commit 971b44e into develop Mar 11, 2024
6 checks passed
@raoulvdberge raoulvdberge deleted the fix/GH-456/carryon branch March 11, 2024 21:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slight incompatibility with 'Carry On' mod
1 participant