Feature/rails 5.2 #3352

bricesanchez · 2018-03-07T04:36:50Z

We support Rails 5.2, we need to have a green build to merge this PR.

We will have to wait for rails 5.2.0.rc2, see: #3352 (comment)

[UPDATE 2018/06/02]:

Wait for this trivial merge: Feature/rails 5 2 parndt/decorators#17

bricesanchez · 2018-03-08T04:11:29Z

Could you help me to find why we have this error?

Failures:

  1) Refinery::Page custom slugs given a page with a custom_slug exists fails validation when a new record uses that custom_slug
     Failure/Error: new_page.valid?

     NoMethodError:
       undefined method `except!' for nil:NilClass
     # /Users/bricesanchez/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/globalize-5.1.0/lib/globalize/active_record/adapter_dirty.rb:45:in `_reset_attribute'
     # /Users/bricesanchez/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/globalize-5.1.0/lib/globalize/active_record/adapter_dirty.rb:16:in `write'
     # /Users/bricesanchez/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/globalize-5.1.0/lib/globalize/active_record/instance_methods.rb:31:in `write_attribute'
     # /Users/bricesanchez/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/globalize-5.1.0/lib/globalize/active_record/class_methods.rb:96:in `block in define_translated_attr_writer'
     # /Users/bricesanchez/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/bundler/gems/friendly_id-80bc0022910e/lib/friendly_id/slugged.rb:380:in `unset_slug_if_invalid'
     # /Users/bricesanchez/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/activemodel-5.2.0.rc1/lib/active_model/validations/callbacks.rb:118:in `run_validations!'
     # /Users/bricesanchez/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/activemodel-5.2.0.rc1/lib/active_model/validations.rb:339:in `valid?'
     # ./pages/spec/models/refinery/page_url_spec.rb:278:in `block (4 levels) in <module:Refinery>'

Also, should we support Rails 5.1 and 5.2 on Refinery 4.1? Drop support of Rails 5.1 for Refinery 4.1? Start using Appraisal gem or wait for a request from the community?

parndt · 2018-03-08T04:23:33Z

core/refinerycms-core.gemspec

@@ -2,7 +2,7 @@
 require File.expand_path('../../core/lib/refinery/version', __FILE__)

 version = Refinery::Version.to_s
-rails_version = ['>= 5.1.0', '< 5.2']
+rails_version = ['>= 5.2.0.rc1', '< 6']


seems like this could stay at >= 5.1.0 and you could specify the rc1 in the Gemfile

At this time the only breaking change between Rails 5.1 and 5.2 is this : 70cd41c

So i'm ok to do what to say.

Any thoughts for this last remaining error undefined method except!' for nil:NilClass` ?

Oh it looks like it's a rails 5.2.0.rc1 bug, mobility gem has also this kind of problem:
shioyama/mobility#164
rails/rails@5fcbdcf

seems like it might be addressed in the next rc

Now use successful?

We don't use it for now

See: rails/rails@8dd76a7

shioyama · 2018-03-21T06:13:43Z

FWIW, released Mobility 0.5.1 with a fix for 5.2.0.rc2. The problematic change in rc1 was reverted.

parndt · 2018-03-21T10:19:25Z

Thanks @shioyama !!

bricesanchez · 2018-06-07T14:08:32Z

@parndt ready to merge?

bricesanchez · 2018-06-13T02:27:40Z

🆙 @parndt 🙃

ttmthanh · 2018-08-15T04:19:20Z

Sorry sir... When can I use this for Rails 5.2 :(

bricesanchez · 2018-08-15T11:21:11Z

@ttmthanh You can use it right now in production mode:

# Gemfile

gem 'refinerycms', git: 'https://github.com/refinery/refinerycms', branch: 'master'

We will release the new gem when #3366 will be finished and merged.

ttmthanh · 2018-08-17T03:26:09Z

@bricesanchez But... What about 'refinerycms-authentication-devise' and 'refinerycms-inquiries' ? Because when I update rails and refinerycms, it has a bit of a conflict.

bricesanchez · 2018-08-17T03:42:04Z

@ttmthanh You could use the master branch for refinerycms-inquiries:
https://github.com/refinery/refinerycms-inquiries

For refinerycms-authentication-devise, i've forget to ask Philip for a review of this PR:
refinery/refinerycms-authentication-devise#40

ttmthanh · 2018-08-17T04:02:54Z

@bricesanchez Please help me ask him :D Thank you very much 👍 😞

bricesanchez · 2018-08-17T04:21:07Z

It's already asked :)

ttmthanh · 2018-08-17T04:25:30Z

gem 'refinerycms-authentication-devise', git: 'https://github.com/refinery/refinerycms-authentication-devise', branch: 'master'
So I could use like this, right? 😃

ttmthanh · 2018-08-20T04:00:30Z

@bricesanchez Sorry sir... Please help me if you are free..

parndt · 2018-08-20T10:06:06Z

@ttmthanh I merged it..

ttmthanh · 2018-08-20T10:08:43Z

@parndt Thanks so much... Because I am trying to use the Active storage service (Rails 5.2) combined with refinerycms..

ttmthanh · 2018-08-21T03:21:14Z

@parndt refinery/refinerycms-page-images#151 Sorry sir...

bricesanchez · 2018-08-21T11:58:31Z

@ttmthanh

@parndt Thanks so much... Because I am trying to use the Active storage service (Rails 5.2) combined with refinerycms..

Nice! We just merged a bugfix with ActiveStorage and Refinery #3385

@parndt refinery/refinerycms-page-images#151 Sorry sir...

You will have to use the feature/mobility branch of refinerycms-page-images until we merge this PR

bricesanchez changed the title ~~WIP: Feature/rails 5 2~~ WIP: Feature/rails 5.2 Mar 8, 2018

bricesanchez force-pushed the feature/rails-5-2 branch from 3a1b9a9 to d20c92f Compare March 8, 2018 03:52

bricesanchez force-pushed the feature/rails-5-2 branch from d20c92f to ee0b74b Compare March 8, 2018 04:12

bricesanchez added this to the 4.1 milestone Mar 8, 2018

parndt reviewed Mar 8, 2018

View reviewed changes

bricesanchez added the Feature Request label Mar 9, 2018

bricesanchez force-pushed the feature/rails-5-2 branch from ee0b74b to b340b26 Compare March 9, 2018 14:11

bricesanchez added 4 commits March 20, 2018 21:01

Let's use Rails 5.2

17ad8cb

Fix deprecated success?

9104715

Now use successful?

Skip active_storage

c1aba77

We don't use it for now

Now use template for routes.rb in cms generator

b577193

See: rails/rails@8dd76a7

bricesanchez force-pushed the feature/rails-5-2 branch from b340b26 to 0a6ac9a Compare March 21, 2018 01:01

bricesanchez modified the milestones: 4.1, 5.0 May 5, 2018

bricesanchez force-pushed the feature/rails-5-2 branch from 046265e to 164c441 Compare June 2, 2018 04:00

bricesanchez modified the milestone: 5.0 Jun 3, 2018

bricesanchez changed the title ~~WIP: Feature/rails 5.2~~ Feature/rails 5.2 Jun 4, 2018

bricesanchez force-pushed the feature/rails-5-2 branch from 265f5a9 to 96fb8bf Compare June 4, 2018 13:02

bricesanchez and others added 3 commits June 4, 2018 09:04

Fix refinery_icon_tag and deprecate this helper

4565bb4

Let's try rails 5.2.0.rc2

9d47cd1

Now use Rails ['>= 5.2.0', '< 6']

decce15

bricesanchez force-pushed the feature/rails-5-2 branch from 96fb8bf to decce15 Compare June 4, 2018 13:04

Merge branch 'master' into feature/rails-5-2

62d7acf

bricesanchez closed this Jun 7, 2018

bricesanchez reopened this Jun 7, 2018

parndt merged commit e49a6be into master Jun 13, 2018

parndt deleted the feature/rails-5-2 branch June 13, 2018 05:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/rails 5.2 #3352

Feature/rails 5.2 #3352

bricesanchez commented Mar 7, 2018 •

edited

Loading

bricesanchez commented Mar 8, 2018

parndt Mar 8, 2018

bricesanchez Mar 8, 2018

bricesanchez Mar 8, 2018 •

edited

Loading

parndt Mar 9, 2018

shioyama commented Mar 21, 2018

parndt commented Mar 21, 2018

bricesanchez commented Jun 7, 2018

bricesanchez commented Jun 13, 2018

ttmthanh commented Aug 15, 2018

bricesanchez commented Aug 15, 2018 •

edited

Loading

ttmthanh commented Aug 17, 2018

bricesanchez commented Aug 17, 2018

ttmthanh commented Aug 17, 2018

bricesanchez commented Aug 17, 2018

ttmthanh commented Aug 17, 2018 •

edited

Loading

ttmthanh commented Aug 20, 2018

parndt commented Aug 20, 2018

ttmthanh commented Aug 20, 2018

ttmthanh commented Aug 21, 2018 •

edited

Loading

bricesanchez commented Aug 21, 2018 •

edited

Loading

Feature/rails 5.2 #3352

Feature/rails 5.2 #3352

Conversation

bricesanchez commented Mar 7, 2018 • edited Loading

bricesanchez commented Mar 8, 2018

parndt Mar 8, 2018

Choose a reason for hiding this comment

bricesanchez Mar 8, 2018

Choose a reason for hiding this comment

bricesanchez Mar 8, 2018 • edited Loading

Choose a reason for hiding this comment

parndt Mar 9, 2018

Choose a reason for hiding this comment

shioyama commented Mar 21, 2018

parndt commented Mar 21, 2018

bricesanchez commented Jun 7, 2018

bricesanchez commented Jun 13, 2018

ttmthanh commented Aug 15, 2018

bricesanchez commented Aug 15, 2018 • edited Loading

ttmthanh commented Aug 17, 2018

bricesanchez commented Aug 17, 2018

ttmthanh commented Aug 17, 2018

bricesanchez commented Aug 17, 2018

ttmthanh commented Aug 17, 2018 • edited Loading

ttmthanh commented Aug 20, 2018

parndt commented Aug 20, 2018

ttmthanh commented Aug 20, 2018

ttmthanh commented Aug 21, 2018 • edited Loading

bricesanchez commented Aug 21, 2018 • edited Loading

bricesanchez commented Mar 7, 2018 •

edited

Loading

bricesanchez Mar 8, 2018 •

edited

Loading

bricesanchez commented Aug 15, 2018 •

edited

Loading

ttmthanh commented Aug 17, 2018 •

edited

Loading

ttmthanh commented Aug 21, 2018 •

edited

Loading

bricesanchez commented Aug 21, 2018 •

edited

Loading